Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for file comment methods #583

Closed
4 of 9 tasks
shaydewael opened this issue Jun 13, 2018 · 0 comments
Closed
4 of 9 tasks

Add deprecation warning for file comment methods #583

shaydewael opened this issue Jun 13, 2018 · 0 comments
Labels
docs M-T: Documentation work only enhancement M-T: A feature request for new functionality

Comments

@shaydewael
Copy link
Contributor

Description

File threads are going to replace file comments, as outlined on the api site. We should add deprecation warnings for files.comments.add and files.comments.edit, since they won't work the same and will soon thereafter cease to exist.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added docs M-T: Documentation work only enhancement M-T: A feature request for new functionality labels Jul 23, 2018
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this issue Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only enhancement M-T: A feature request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants