Description

https://slackapi.github.io/node-slack-sdk/web_api#using-a-callback-instead-of-a-promise lists the following example:

web.channels.list((err, res) => {
  if (err) {
    return console.error(err);
  }

  // `res` contains information about the channels
  res.channels.forEach(c => console.log(c.name));
});

While, web.channels.list({}, callback) does work, when omitting the options parameter the callback will not be called due to

When compiled to JS, apiCall has a signature of function (method, options, callback) {}. If options is not passed, callback will be undefined and a promise will be returned instead.

A potential solution would be to check typeof options === 'function' to see if options is actually the callback.

What type of issue is this?

• bug
• enhancement (feature request)
• question
• documentation related
• testing related
• discussion

Requirements (place an x in each of the [ ])

• I've read and understood the Contributing guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.
• I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Reproducible in:

@slack/client version: 4.4.0, also verified in 4.0.0

node version: 8.11.4

OS version(s): macOS High Sierra

Steps to reproduce:

1. Run example in https://slackapi.github.io/node-slack-sdk/web_api#using-a-callback-instead-of-a-promise

Expected result:

Channels should be logged

Actual result:

No channels logged due to callback not being called.