Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for node versions before v8 LTS #690

Closed
3 tasks done
aoberoi opened this issue Feb 8, 2019 · 0 comments
Closed
3 tasks done

Drop support for node versions before v8 LTS #690

aoberoi opened this issue Feb 8, 2019 · 0 comments
Labels
area:typescript issues that specifically impact using the package from typescript projects docs M-T: Documentation work only semver:major tests M-T: Testing work only
Milestone
v5 - Major versio...

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Feb 8, 2019

Description

Adjust the test matrix so that we only test on versions we care to.

We should also update the documentation to state the supported versions.

Lastly, there may be some work to update type definitions to the appropriate versions.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added docs M-T: Documentation work only tests M-T: Testing work only area:typescript issues that specifically impact using the package from typescript projects labels Feb 8, 2019
@aoberoi aoberoi added this to the v5 - Major version update milestone Feb 8, 2019
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this issue Mar 6, 2019
@aoberoi
drops support for node < v8 LTS, fixes slackapi#690
f313ace
@aoberoi aoberoi mentioned this issue Mar 6, 2019
Merged
2 tasks
@aoberoi aoberoi closed this as completed Mar 8, 2019
@aoberoi aoberoi mentioned this issue Sep 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:typescript issues that specifically impact using the package from typescript projects docs M-T: Documentation work only semver:major tests M-T: Testing work only
Projects
None yet
Milestone
v5 - Major version update
Development

No branches or pull requests
1 participant
@aoberoi