Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove token rotation implementation for deprecated Workspace Apps #696

Closed
3 tasks done
aoberoi opened this issue Feb 8, 2019 · 1 comment
Closed
3 tasks done

Remove token rotation implementation for deprecated Workspace Apps #696

aoberoi opened this issue Feb 8, 2019 · 1 comment
Labels
enhancement M-T: A feature request for new functionality semver:major
Milestone
v5 - Major versio...

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Feb 8, 2019

Since we're no longer shipping Workspace Apps, and the token rotation code is unused in all other apps, now is a good time to shrink the API contract, to make room for other kinds of implementations in the future.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added semver:major enhancement M-T: A feature request for new functionality labels Feb 8, 2019
@aoberoi aoberoi added this to the v5 - Major version update milestone Feb 8, 2019
@aoberoi
Copy link
Contributor Author

aoberoi commented Feb 8, 2019

we might also want to remove the use of the X-Slack-User header.

aoberoi added a commit to aoberoi/node-slack-sdk that referenced this issue Feb 13, 2019
@aoberoi
warns when using the deprecated token refresh. see slackapi#696
1cae411
@aoberoi aoberoi mentioned this issue Feb 13, 2019
Merged
2 tasks
@shaydewael shaydewael mentioned this issue Mar 5, 2019
Merged
2 tasks
@aoberoi aoberoi closed this as completed Mar 6, 2019
@aoberoi aoberoi mentioned this issue Mar 11, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement M-T: A feature request for new functionality semver:major
Projects
None yet
Milestone
v5 - Major version update
Development

No branches or pull requests
1 participant
@aoberoi