Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebClient: Add warning each time a request fails before being retried. #718

Closed
3 tasks done
aoberoi opened this issue Mar 7, 2019 · 0 comments
Closed
3 tasks done
Labels
enhancement M-T: A feature request for new functionality

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Mar 7, 2019

Description

Currently, when a request is failing due to a an HTTP error, a read error, or another request error (not platform error or rate-limiting error), its very hard to know this during development.

The reason is that the default retry policy allows retries for up to 30 minutes. This is useful in production, which retrying is more likely to give your app resiliency to production issues on either your side or Slack's side. However, in development this just impedes your ability to understand a failure ever occurred.

I recently faced this issue when using a custom TLS configuration. This was causing an error, but since I did not have DEBUG logging enabled, I had no idea the request was being retried.

The proposal is to change the log level of this line to warn and to add information about the error:

this.logger.debug('http request failed');

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added the enhancement M-T: A feature request for new functionality label Mar 7, 2019
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this issue Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

No branches or pull requests

1 participant