Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow App Home to use Input Blocks #853

Closed
1 of 4 tasks
fwump38 opened this issue Oct 18, 2020 · 1 comment · Fixed by #854
Closed
1 of 4 tasks

Allow App Home to use Input Blocks #853

fwump38 opened this issue Oct 18, 2020 · 1 comment · Fixed by #854
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x Version: 3x
Milestone
2.9.3

Comments

@fwump38
Copy link
Contributor

fwump38 commented Oct 18, 2020

According to BlockKit Reference Input Blocks are now allowed on the App Home however this JsonValidator for the View class prevents this.

Category (place an x in each of the [ ])

  • slack.web.WebClient (Web API client)
  • slack.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack.web.classes (UI component builders)
  • slack.rtm.RTMClient (RTM client)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
@fwump38 fwump38 mentioned this issue Oct 18, 2020
Merged
9 tasks
@seratch seratch added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x Version: 3x and removed untriaged labels Oct 18, 2020
@seratch seratch added this to the 2.9.3 milestone Oct 18, 2020
@seratch
Copy link
Member

seratch commented Oct 18, 2020

Thanks, you're right. As you mentioned, now that you can use input blocks in App Home as well, the validation logic is no longer valid.

@dependabot dependabot bot mentioned this issue Mar 17, 2021
Closed
@kbroughton kbroughton mentioned this issue Aug 27, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x Version: 3x
Projects
None yet
Milestone
2.9.3
Development

Successfully merging a pull request may close this issue.

Removed JsonValidator to allow App Home to use Input Blocks
2 participants
@seratch @fwump38