-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axios Post Request fails behind HTTP Proxy #131
Comments
Hi @EHitchcockIAG, thanks a lot for writing in with details! Can you help me understand the need you described here? The scenario is that you have a public proxy endpoint and you would like to use it for Slack webhook requests from a GitHub Actions job, right? If yes, this feature request makes sense to me and I think we should support it in future versions. |
Hi @seratch,, Our use case is to trigger a Slack webhook from a Github runner running behind a corporate HTTP proxy. Requests are blocked to the wider web from the Github runner unless routed through the corporate proxy. Cheers |
Help me better understand your situation a bit more. Does it mean you use on-premise github enterprise? |
We are using Github SaaS (not the on-premise enterprise version) with an Organization, and the runner agents within this organization are AWS hosted runners |
Ah I see. This makes sense. Thanks for answering! Our team is happy to have your contribution! |
Description
Describe your issue here.
What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)Bug Report
When Axios POSTs the request to HTTPS webhook (to trigger Slack Workflow) on a Github Runner acting behind a HTTP proxy, the request will hang forever. This is due to an outstanding Axios bug which hasn't been fixed.
Reproducible in:
package version: 1.22.0
node version: 16.14.2
OS version(s): Amazon Linux 2
Steps to reproduce:
Expected result:
Github Workflow passes and Webhook triggers Slack Workflow.
Actual result:
slackapi/slack-github-action runs forever in Github Workflow.
Attachments:
I was able to resolve this by configuring an https-proxy-agent when the request webhook uses HTTPS and the proxy uses HTTP. Link to PR in fork https://github.com/EHitchcockIAG/slack-github-action-debug/pull/2/files. Currently we are using the tag
v1.23.0-alpha
from the fork in our Github Workflows.I'm not sure if this is an adequate solution by the team's standards. If this looks okay, I can add some tests and open a PR to main.
The text was updated successfully, but these errors were encountered: