Convert chunk manager to use listenable futures with cancellation #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthacker
reviewed
Nov 22, 2022
danhermann
reviewed
Nov 22, 2022
kaldb/src/main/java/com/slack/kaldb/chunkManager/ChunkManagerBase.java
Outdated
Show resolved
Hide resolved
kaldb/src/main/java/com/slack/kaldb/chunkManager/ChunkManagerBase.java
Outdated
Show resolved
Hide resolved
mansu
previously requested changes
Nov 22, 2022
bryanlb
force-pushed
the
bburkholder/chunk-manager-base-futures
branch
from
b5ad992
to
f9c9ab4
Compare
mansu
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the chunk manager to use listenable futures, which can be interrupted, instead of completable futures which cannot. This also should address a long standing todo to return an exception when all results return an error and now returns the exception instead of an empty result.