Tweak BackStackRecordLocalProvider to get it building on iOS again #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kotlin/Native optimizer seems to have issues with some static properties. This PR tweaks BackStackRecordLocalProvider to avoid the offending initializers all together. This does mean that we lose the CompositionLocal, but it's internal and not overridden anywhere anyway.
chrisbanes
commented
Dec 21, 2023
chrisbanes
commented
Dec 21, 2023
ZacSweers
approved these changes
Dec 21, 2023
|
Not sure if the CI failure is because you opened the PR and thus don't have access to the secret, will merge past it for now |
|
It passed earlier, so might just be a fluke. Hopefully the re-run goes green. |
Ah, yeah I don't have access to the secret. When I said it passed earlier, I meant it passed in my fork before rebasing on to your emulator changes. |
|
talking with the ewtf people about options for this async |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kotlin/Native optimizer seems to have issues with some static properties (issue here).
This PR tweaks BackStackRecordLocalProvider to avoid the offending initializers all together. This does mean that we lose the
CompositionLocal, but it's internal and not overridden anywhere anyway.Closes #1075