Navigator - Change popRoot to keep the top screen as the root screen #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
approved these changes
Mar 13, 2024
| backStackSize-- | ||
| pop() | ||
| Snapshot.withMutableSnapshot { | ||
| // Move the top screen to be the root screen for any final animation. |
There was a problem hiding this comment.
Can you flesh this out with a little more detail (similar to what you put in the PR description) for posterity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying this as the full
popUntilstyle would result in the root of the backstack being shown.Changing to "move" the top screen to the root and then
pop.