Stop forcing Jetpack Compose compiler plugin #704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @koalaparadise to sign the Salesforce Inc. Contributor License Agreement. |
At the moment, the Jetpack Compose compiler plugin is force used on all Kotlin tasks. The JC compiler only works for Android and Desktop, which means that downstream users can't use the artifacts on other KMP targets (such as iOS). The JB Compose Multiplatform Gradle plugin auto sets up their Compose compiler plugin, so there's no need for the override. The Jetpack Compose compiler is already setup for Android projects through the `commonAndroidConfig`, so again no need for the override.
chrisbanes
force-pushed
the
cb/use-mp-compose-compiler
branch
from
f56652b
to
99162b2
Compare
|
Thanks for the contribution! Before we can merge this, we need @chrisbanes to sign the Salesforce Inc. Contributor License Agreement. |
ZacSweers
approved these changes
Jun 30, 2023
chrisbanes
added a commit
to chrisbanes/tivi
that referenced
this pull request
Jun 30, 2023
We need slackhq/circuit#704 for iOS and Native support.
|
Just in case anyone needs this immediately, I've published a fork containing this PR: |
chrisbanes
added a commit
to chrisbanes/tivi
that referenced
this pull request
Jun 30, 2023
We need slackhq/circuit#704 for iOS and Native support.
|
Going to backport some changes from #643 to better support this |
ZacSweers
added a commit
that referenced
this pull request
Jun 30, 2023
Continuation from #704 --------- Co-authored-by: Chris Banes <chris@banes.me>
chrisbanes
added a commit
to chrisbanes/tivi
that referenced
this pull request
Jul 1, 2023
We need slackhq/circuit#704 for iOS and Native support.
chrisbanes
added a commit
to chrisbanes/tivi
that referenced
this pull request
Jul 1, 2023
We need slackhq/circuit#704 for iOS and Native support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the Jetpack Compose compiler plugin is force used on all Kotlin tasks. The JC compiler only works for Android and Desktop, which means that downstream users can't use the artifacts on other KMP targets (such as iOS).
The JB Compose Multiplatform Gradle plugin auto sets up their Compose compiler plugin, so there's no need for the override. The Jetpack Compose compiler is already setup for Android projects through the
commonAndroidConfig, so again no need for the override.