Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HtmlWebpackPlugin@4 support #23

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

AnujRNair
Copy link
Contributor

Summary

Building off of PR #16, this PR adds HtmlWebpackPlugin@4 support to the CspHtmlWebpackPlugin.

Opted to move the require to the top of the file to ensure we load it once and reference it - also keeps the requires a little more together for easier debugging.

Credits go to @sibiraj-s for the initial implementation in the PR linked above

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #23 into master will decrease coverage by 1.56%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   98.88%   97.32%   -1.57%     
==========================================
  Files           2        2              
  Lines         180      187       +7     
  Branches       12       14       +2     
==========================================
+ Hits          178      182       +4     
- Misses          2        5       +3
Impacted Files Coverage Δ
plugin.js 93.05% <62.5%> (-3.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cedba7...4ce874b. Read the comment docs.

@AnujRNair AnujRNair merged commit 7fb3efb into master Dec 19, 2018
@AnujRNair AnujRNair deleted the an-html-webpack-plugin-4-support branch December 19, 2018 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant