Make codegen slightly more robust

slackhq · May 9, 2023 · e27e311 · e27e311
1 parent 3d84003
commit e27e311
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/BuildSchemaCLI.php b/src/BuildSchemaCLI.php
@@ -118,16 +118,16 @@ public static function getRenderedHackTableSchema(
 				$file_contents .= $indentation."\t\t\t\t'{$field->name}',\n";
 				$file_contents .= $indentation."\t\t\t\tDataType::{$field->type},\n";
 				$file_contents .= $indentation."\t\t\t\t{$field->length},\n";
-				$file_contents .= $indentation."\t\t\t\t" . ($field->null ? 'true' : 'false') . ",\n";
+				$file_contents .= $indentation."\t\t\t\t" . \var_export($field->null, true) . ",\n";
 				$file_contents .= $indentation."\t\t\t\t'{$field->hack_type}',\n";
 				if ($field->unsigned is nonnull || $field->default is nonnull) {
 					if ($field->unsigned is nonnull) {
-						$file_contents .= $indentation."\t\t\t\t" . ($field->unsigned ? 'true' : 'false') . ",\n";
+						$file_contents .= $indentation."\t\t\t\t" . \var_export($field->unsigned, true) . ",\n";
 					} else {
 						$file_contents .= $indentation."\t\t\t\tnull,\n";
 					}
 					if ($field->default is nonnull) {
-						$file_contents .= $indentation."\t\t\t\t'{$field->default}',\n";
+						$file_contents .= $indentation."\t\t\t\t\"{$field->default}\",\n";
 					}
 				}
 				$file_contents .= $indentation."\t\t\t),\n";

diff --git a/tests/fixtures/expected_schema.codegen b/tests/fixtures/expected_schema.codegen
@@ -87,7 +87,7 @@ function get_my_table_schemas(): dict<string, dict<string, TableSchema>> {
 						false,
 						'int',
 						true,
-						'0',
+						"0",
 					),
 					new Column(
 						'name',