Ensure hhvm 4.40 compatibility #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The needs_another_plus_plus hack is terrible. However, I must conditionally increment the pointer depending on - Is the LHS of the while's && false, then no. - Did we fall out of the loop because pointer is zero, then yes.
…nto hhvm_4_40_compat
|
I hope Slack is at least on HHVM 4.15, otherwise, you won't be able to use this. |
ssandler
reviewed
Jan 20, 2020
| @@ -32,13 +32,12 @@ public function aliasRecentExpression(string $name): void { | |||
| /** | |||
| * The FROM clause of the query gets processed first, retrieving data from tables, executing subqueries, and handling joins | |||
| * This is also where we build up the $columns list which is commonly used throughout the entire library to map column references to indexes in this dataset | |||
| * @reviewer, we don't build up the $columns, since the variable is unused... | |||
There was a problem hiding this comment.
ah yeah, this is from an older version of this before schema was present I think!
ssandler
approved these changes
Jan 20, 2020
|
Thank you for doing this 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The needs_another_plus_plus hack is terrible.
However, I must conditionally increment the pointer depending on