Fix unnecessary type alias issues

src/code_info/t_atomic.rs

@@ -1698,20 +1698,6 @@ pub fn populate_atomic_type(
                 force,
             );
         }
-        TAtomic::TTypeAlias {
-            type_params: Some(ref mut type_params),
-            ..
-        } => {
-            for type_param in type_params {
-                populate_union_type(
-                    type_param,
-                    codebase_symbols,
-                    reference_source,
-                    symbol_references,
-                    force,
-                );
-            }
-        }
         TAtomic::TVec {
             ref mut type_param,
             ref mut known_items,
@@ -1739,17 +1725,24 @@ pub fn populate_atomic_type(
         }
         TAtomic::TNamedObject {
             name,
-            type_params: Some(ref mut type_params),
+            ref mut type_params,
+            ..
+        }
+        | TAtomic::TTypeAlias {
+            name,
+            ref mut type_params,
             ..
         } => {
-            for type_param in type_params {
-                populate_union_type(
-                    type_param,
-                    codebase_symbols,
-                    reference_source,
-                    symbol_references,
-                    force,
-                );
+            if let Some(type_params) = type_params {
+                for type_param in type_params {
+                    populate_union_type(
+                        type_param,
+                        codebase_symbols,
+                        reference_source,
+                        symbol_references,
+                        force,
+                    );
+                }
             }
 
             match reference_source {

tests/diff/classOnlyReferencedInAnotherProperty/a/bar.hack

@@ -0,0 +1,5 @@
+<<__EntryPoint>>
+function main() {
+    $a = new A("hello");
+    echo $a->value;
+}

tests/diff/classOnlyReferencedInAnotherProperty/a/foo.hack

@@ -0,0 +1,8 @@
+final class A<T> {
+	public ?B<T> $b = null;
+    public function __construct(public T $value) {}
+}
+
+final class B<T> {
+	public function __construct(public T $value) {}
+}

tests/diff/classOnlyReferencedInAnotherProperty/b/bar.hack

@@ -0,0 +1,5 @@
+<<__EntryPoint>>
+function main() {
+    $a = new A("bello");
+    echo $a->value;
+}

tests/diff/classOnlyReferencedInAnotherProperty/b/foo.hack

@@ -0,0 +1,8 @@
+final class A<T> {
+	public ?B<T> $b = null;
+    public function __construct(public T $value) {}
+}
+
+final class B<T> {
+	public function __construct(public T $value) {}
+}

tests/diff/classOnlyReferencedInAnotherProperty/output.txt

@@ -0,0 +1,2 @@
+ERROR: UnusedPublicOrProtectedProperty - foo.hack:2:46 - Unused public or protected property ApiResourcePermissions::$experiment
+ERROR: UnusedPublicOrProtectedProperty - foo.hack:7:39 - Unused public or protected property ApiResourcePermissionsExperiment::$value

tests/diff/invalidateShapesIdx/a/bar.hack

@@ -0,0 +1,8 @@
+<<__EntryPoint>>
+function main() {
+    bar(shape('a' => 10, 'b' => 'a'));
+}
+
+function bar(foo_t $foo) {
+    echo Shapes::idx($foo, 'b', null);
+}

tests/diff/invalidateShapesIdx/a/foo.hack

@@ -0,0 +1,4 @@
+type foo_t = shape(
+	'a' => int,
+	?'b' => string,
+);

tests/diff/invalidateShapesIdx/b/bar.hack

@@ -0,0 +1,8 @@
+<<__EntryPoint>>
+function main() {
+    bar(shape('a' => 10, 'b' => 'a'));
+}
+
+function bar(foo_t $foo) {
+    echo Shapes::idx($foo, 'b', null);
+}

tests/diff/invalidateShapesIdx/b/foo.hack

@@ -0,0 +1,4 @@
+type foo_t = shape(
+	'a' => int,
+	'b' => string,
+);

tests/diff/invalidateShapesIdx/output.txt

@@ -0,0 +1 @@
+ERROR: UnnecessaryShapesIdx - bar.hack:7:10 - The field 'b' is always present on the shape -- consider using $foo['b'] instead