Add final/abstract identifiers to tests where appropriate

slackhq · May 21, 2024 · 3c222a8 · 3c222a8
1 parent 9bf7692
commit 3c222a8
Show file tree

Hide file tree

Showing 449 changed files with 693 additions and 688 deletions.
diff --git a/tests/diff/addClassInOtherFile/b/A.hack b/tests/diff/addClassInOtherFile/b/A.hack
@@ -1 +1 @@
-class A {}
+final class A {}
diff --git a/tests/diff/addTrait/a/input.hack b/tests/diff/addTrait/a/input.hack
@@ -2,7 +2,7 @@ trait T {
     public function foo(): void {}
 }
 
-class C {
+final class C {
 }
 
 function foo(C $c) {

diff --git a/tests/diff/addTrait/b/input.hack b/tests/diff/addTrait/b/input.hack
@@ -2,7 +2,7 @@ trait T {
     public function foo(): void {}
 }
 
-class C {
+final class C {
     use T;
 }
 

diff --git a/tests/diff/changeAliasedShapeType/a/input.hack b/tests/diff/changeAliasedShapeType/a/input.hack
@@ -3,7 +3,7 @@ function main(): void {
     A::takes_bar(shape('a' => foo_t::A));
 }
 
-class A {
+final class A {
     public static function takes_bar(bar_t $b) {
         if ($b['a'] == foo_t::A) {}
     }

diff --git a/tests/diff/changeAliasedShapeType/b/input.hack b/tests/diff/changeAliasedShapeType/b/input.hack
@@ -3,7 +3,7 @@ function main(): void {
     A::takes_bar(shape('a' => foo_t::A));
 }
 
-class A {
+final class A {
     public static function takes_bar(bar_t $b) {
         if ($b['a'] == foo_t::A) {}
     }

diff --git a/tests/diff/changeAliasedShapeType/c/input.hack b/tests/diff/changeAliasedShapeType/c/input.hack
@@ -3,7 +3,7 @@ function main(): void {
     A::takes_bar(shape('a' => Foo::A));
 }
 
-class A {
+final class A {
     public static function takes_bar(bar_t $b) {
         if ($b['a'] == Foo::A) {}
     }

diff --git a/tests/diff/changePrivateMethodBehaviour/a/input.hack b/tests/diff/changePrivateMethodBehaviour/a/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     public function foo(): void {
         $this->bar();
     }

diff --git a/tests/diff/changePrivateMethodBehaviour/b/input.hack b/tests/diff/changePrivateMethodBehaviour/b/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     public function foo(): void {
         $this->bar();
     }

diff --git a/tests/diff/classConstTypeChanged/a/input.hack b/tests/diff/classConstTypeChanged/a/input.hack
@@ -2,7 +2,7 @@ abstract class A {
   abstract const type T;
 }
 
-class B extends A {
+final class B extends A {
     const type T = vec<string>;
 
     public function bar(): void {}

diff --git a/tests/diff/classConstTypeChanged/b/input.hack b/tests/diff/classConstTypeChanged/b/input.hack
@@ -2,7 +2,7 @@ abstract class A {
   abstract const type T;
 }
 
-class B extends A {
+final class B extends A {
     const type T = vec<Exception>;
 
     public function bar(): void {}

diff --git a/tests/diff/commentOutClassInOtherFile/a/A.hack b/tests/diff/commentOutClassInOtherFile/a/A.hack
@@ -1 +1 @@
-class A extends Exception {}
+final class A extends Exception {}
diff --git a/tests/diff/commentOutClassInOtherFile/a/input.hack b/tests/diff/commentOutClassInOtherFile/a/input.hack
@@ -12,7 +12,7 @@ function bar(): void {
     echo A::class;
 }
 
-class B {
+final class B {
     public function baz(): void {
         echo A::class;
     }

diff --git a/tests/diff/commentOutClassInOtherFile/b/input.hack b/tests/diff/commentOutClassInOtherFile/b/input.hack
@@ -12,7 +12,7 @@ function bar(): void {
     echo A::class;
 }
 
-class B {
+final class B {
     public function baz(): void {
         echo A::class;
     }

diff --git a/tests/diff/extendedRefLost/a/input.hack b/tests/diff/extendedRefLost/a/input.hack
@@ -1,6 +1,6 @@
 abstract class A {}
 
-class B extends A {}
+final class B extends A {}
 
 function foo(): void {}
 

diff --git a/tests/diff/extendedRefLost/b/input.hack b/tests/diff/extendedRefLost/b/input.hack
@@ -1,6 +1,6 @@
 abstract class A {}
 
-class B {}
+final class B {}
 
 function foo(): void {}
 

diff --git a/tests/diff/methodUsedThroughTrait/a/input.hack b/tests/diff/methodUsedThroughTrait/a/input.hack
@@ -7,7 +7,7 @@ trait ParentTrait {
 	public function doThing(): void {}
 }
 
-class ConcreteClass extends ParentClass {
+final class ConcreteClass extends ParentClass {
 	use ParentTrait;
 }
 

diff --git a/tests/diff/methodUsedThroughTrait/b/input.hack b/tests/diff/methodUsedThroughTrait/b/input.hack
@@ -7,7 +7,7 @@ trait ParentTrait {
 	public function doThing(): void {}
 }
 
-class ConcreteClass extends ParentClass {
+final class ConcreteClass extends ParentClass {
 	use ParentTrait;
 }
 

diff --git a/tests/diff/methodWithErrorSuppressed/a/input.hack b/tests/diff/methodWithErrorSuppressed/a/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     public function foo(vec<string> $vecs): void {
         echo "a";
         if ($vecs is nonnull) {}

diff --git a/tests/diff/methodWithErrorSuppressed/b/input.hack b/tests/diff/methodWithErrorSuppressed/b/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     public function foo(vec<string> $vecs): void {
         echo "a";
         /* HAKANA_FIXME[RedundantNonnullTypeComparison] */

diff --git a/tests/diff/removeClassInOtherFile/a/A.hack b/tests/diff/removeClassInOtherFile/a/A.hack
@@ -1 +1 @@
-class A {}
+final class A {}
diff --git a/tests/diff/removeParentMethod/a/input.hack b/tests/diff/removeParentMethod/a/input.hack
@@ -1,4 +1,4 @@
-class B extends A {
+final class B extends A {
     public function bar(): void {
         $this->foo();
     }

diff --git a/tests/diff/removeParentMethod/a/parent.hack b/tests/diff/removeParentMethod/a/parent.hack
@@ -1,3 +1,3 @@
-class A {
+abstract class A {
     public function foo(): void {}
 }
diff --git a/tests/diff/removeParentMethod/b/input.hack b/tests/diff/removeParentMethod/b/input.hack
@@ -1,4 +1,4 @@
-class B extends A {
+final class B extends A {
     public function bar(): void {
         $this->foo();
     }

diff --git a/tests/diff/removeParentMethod/b/parent.hack b/tests/diff/removeParentMethod/b/parent.hack
@@ -1,3 +1,3 @@
-class A {
+abstract class A {
 
 }
diff --git a/tests/diff/removeTrait/a/input.hack b/tests/diff/removeTrait/a/input.hack
@@ -2,7 +2,7 @@ trait T {
     public function foo(): void {}
 }
 
-class C {
+final class C {
     use T;
 }
 

diff --git a/tests/diff/removeTrait/b/input.hack b/tests/diff/removeTrait/b/input.hack
@@ -2,7 +2,7 @@ trait T {
     public function foo(): void {}
 }
 
-class C {
+final class C {
 }
 
 function foo(C $c) {

diff --git a/tests/diff/replaceImplementationAndUse/a/input.hack b/tests/diff/replaceImplementationAndUse/a/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     private function __construct(private int $i) {}
 
     public static function gen(): A {

diff --git a/tests/diff/replaceImplementationAndUse/b/input.hack b/tests/diff/replaceImplementationAndUse/b/input.hack
@@ -1 +1 @@
-class A { }
+final class A { }
diff --git a/tests/diff/replaceImplementationAndUseWithExtends/a/input.hack b/tests/diff/replaceImplementationAndUseWithExtends/a/input.hack
@@ -1,12 +1,12 @@
-class A {
+abstract class A {
     private function __construct(private int $i) {}
 
     public function returnSelf() : A {
         return new A(5);
     }
 }
 
-class B extends A {
+final class B extends A {
     public function returnSelf(): A {
         return parent::returnSelf();
     }

diff --git a/tests/diff/replaceImplementationAndUseWithExtends/b/input.hack b/tests/diff/replaceImplementationAndUseWithExtends/b/input.hack
@@ -1 +1 @@
-class A { }
+final class A { }
diff --git a/tests/diff/uncommentClassInOtherFile/a/input.hack b/tests/diff/uncommentClassInOtherFile/a/input.hack
@@ -11,7 +11,7 @@ function bar(): void {
     echo A::class;
 }
 
-class B {
+final class B {
     public function baz(): void {
         echo A::class;
     }

diff --git a/tests/diff/uncommentClassInOtherFile/b/A.hack b/tests/diff/uncommentClassInOtherFile/b/A.hack
@@ -1 +1 @@
-class A extends Exception {}
+final class A extends Exception {}
diff --git a/tests/diff/uncommentClassInOtherFile/b/input.hack b/tests/diff/uncommentClassInOtherFile/b/input.hack
@@ -11,7 +11,7 @@ function bar(): void {
     echo A::class;
 }
 
-class B {
+final class B {
     public function baz(): void {
         echo A::class;
     }

diff --git a/tests/diff/unusedFunctionRemovedWholeFile/a/input.hack b/tests/diff/unusedFunctionRemovedWholeFile/a/input.hack
@@ -3,4 +3,4 @@ function main(): void {
     new B();
 }
 
-class B {}
+final class B {}
diff --git a/tests/diff/unusedFunctionRemovedWholeFile/b/input.hack b/tests/diff/unusedFunctionRemovedWholeFile/b/input.hack
@@ -2,4 +2,4 @@
 function main(): void {
 }
 
-class B {}
+final class B {}
diff --git a/tests/fix/UnusedClass/removeUnusedClass/input.hack b/tests/fix/UnusedClass/removeUnusedClass/input.hack
@@ -1,10 +1,10 @@
 // This is my class
 // it is not used
-class A {
+final class A {
     // some stuff
 }
 
-class B {}
+final class B {}
 
 <<__EntryPoint>>
 function foo(): void {

diff --git a/tests/fix/UnusedClass/removeUnusedClass/output.txt b/tests/fix/UnusedClass/removeUnusedClass/output.txt
@@ -1,6 +1,6 @@
 
 
-class B {}
+final class B {}
 
 <<__EntryPoint>>
 function foo(): void {

diff --git a/tests/fix/UnusedPrivateMethod/simple/input.hack b/tests/fix/UnusedPrivateMethod/simple/input.hack
@@ -1,4 +1,4 @@
-class Foo {
+final class Foo {
     /** cool doc */
     private function bar(): void {}
 }

diff --git a/tests/fix/UnusedPrivateMethod/simple/output.txt b/tests/fix/UnusedPrivateMethod/simple/output.txt
@@ -1,4 +1,4 @@
-class Foo {
+final class Foo {
 }
 
 <<__EntryPoint>>

diff --git a/tests/inference/Arg/callMapClassOptionalArg/input.hack b/tests/inference/Arg/callMapClassOptionalArg/input.hack
@@ -1,3 +1,3 @@
-class Hello {}
+final class Hello {}
 $m = new ReflectionMethod(Hello::class, "goodbye");
 $m->invoke(null, "cool");
diff --git a/tests/inference/ArrayAccess/arrayAccessAfterPassByref/input.hack b/tests/inference/ArrayAccess/arrayAccessAfterPassByref/input.hack
@@ -1,4 +1,4 @@
-class Arr {
+final class Arr {
     public static function pull(inout dict<string, mixed> $a, string $b, mixed $c = null): mixed {
         return $a[$b] ?? $c;
     }

diff --git a/tests/inference/ArrayAccess/instanceOfIntOffset/input.hack b/tests/inference/ArrayAccess/instanceOfIntOffset/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     public function fooFoo(): void { }
 }
 function bar (vec<mixed> $a): void {

diff --git a/tests/inference/ArrayAccess/instanceOfStringOffset/input.hack b/tests/inference/ArrayAccess/instanceOfStringOffset/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     public function fooFoo(): void { }
 }
 function bar (dict<string, mixed> $a): void {

diff --git a/tests/inference/ArrayAssignment/ArrayDimOffsetStringable/input.hack b/tests/inference/ArrayAssignment/ArrayDimOffsetStringable/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
 	public function __toString(){return "";}
 }
 

diff --git a/tests/inference/ArrayAssignment/checkEmptinessAfterConditionalArrayAdjustment/input.hack b/tests/inference/ArrayAssignment/checkEmptinessAfterConditionalArrayAdjustment/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     public dict<arraykey, mixed> $arr = dict[];
 
     public function foo() : void {

diff --git a/tests/inference/ArrayAssignment/listPropertyAssignmentAfterIsset/input.hack b/tests/inference/ArrayAssignment/listPropertyAssignmentAfterIsset/input.hack
@@ -1,4 +1,4 @@
-class Collection {
+final class Collection {
     private vec<string> $list = dict[];
 
     public function override(int $offset): void {

diff --git a/tests/inference/ArrayFunctionCall/arrayFilterIgnoreNullable/input.hack b/tests/inference/ArrayFunctionCall/arrayFilterIgnoreNullable/input.hack
@@ -1,4 +1,4 @@
-class A {
+final class A {
     public function getRows() : vec<?A> {
         return vec[new A(), null];
     }

diff --git a/tests/inference/ArrayFunctionCall/keepClassStringInOffsetThroughArrayMerge/input.hack b/tests/inference/ArrayFunctionCall/keepClassStringInOffsetThroughArrayMerge/input.hack
@@ -1,5 +1,5 @@
 
-class A {
+final class A {
     private dict<classname<A>, string> $a;
 
     public function __construct() {

diff --git a/tests/inference/Async/awaitNullable/input.hack b/tests/inference/Async/awaitNullable/input.hack
@@ -1,10 +1,10 @@
-class A {
+final class A {
   public async function bar(): Awaitable<string> {
     return "a";
   }
 }
 
-class Boo {
+final class Boo {
     public static async function getA(): Awaitable<?A> {
         return new A();
     }

diff --git a/tests/inference/Async/awaitWithPropertyAssertions/input.hack b/tests/inference/Async/awaitWithPropertyAssertions/input.hack
@@ -1,4 +1,4 @@
-class B {
+final class B {
   public function bar(): ?string {
     return "a";
   }

diff --git a/tests/inference/Attribute/allowsClassStringFromDifferentNamespace/input.hack b/tests/inference/Attribute/allowsClassStringFromDifferentNamespace/input.hack
@@ -2,22 +2,22 @@
 namespace NamespaceOne {
     use Attribute;
 
-    class FooAttribute implements HH\ClassAttribute
+    final class FooAttribute implements HH\ClassAttribute
     {
         public function __construct(private classname<FoobarInterface> $className)
         {}
     }
 
     interface FoobarInterface {}
 
-    class Bar implements FoobarInterface {}
+    final class Bar implements FoobarInterface {}
 }
 
 namespace NamespaceTwo {
     use NamespaceOne\FooAttribute;
     use NamespaceOne\Bar as ZZ;
 
     <<FooAttribute(ZZ::class)>>
-    class Baz {}
+    final class Baz {}
 }