Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to AGP 8/Gradle 8 #117

Merged
merged 70 commits into from
Apr 15, 2023
Merged

Update to AGP 8/Gradle 8 #117

merged 70 commits into from
Apr 15, 2023

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Feb 2, 2023 •
edited

Going off this recipe: https://github.com/android/gradle-recipes/tree/agp-8.0/Groovy/getAllClassesTest

Other stuff

  • Update CI to use ATDs (faster)
  • Update build infra to use more modern gradle APIs (toolchains, version catalogs, dependency management in settings.gradle, etc)
  • Seems proguard files are no longer accessible to androidTest variants, filed https://issuetracker.google.com/issues/269089136
    • Workaround now is to use artifactFiles instead of resolved artifacts
  • Fix configuration caching in tests with latest gradle version
  • Add an opt-out mechanism for consuming test proguard rules as it seems to not convey a relevant task dependency

Resolves #109

@ZacSweers
Gradle 8.0-rc-1
68d3ea3
@ZacSweers
Update deps
27726d3
@ZacSweers
Update CI
a47655b
@ZacSweers
Update artifacts API
2c770f7
@ZacSweers
fix CI
dbb280e
@ZacSweers
19
8925c83
@ZacSweers
Restore cache
fa31668
@ZacSweers
API
62194f5
@ZacSweers
Replace classpath prop
7007a51
@ZacSweers
Remove unused function
6813c59
@ZacSweers
Add missing sensitivities
eefed80
@ZacSweers
Use resolve b/199411018
556fe04
@ZacSweers
Remove appExtension where possible
c1a4305
@ZacSweers
Use ALL scope
d7fd63f
@ZacSweers
Comment + distinct and sorted for determinism
d71b897
@ZacSweers
Don't run as parameterized
9f7a6e5
@ZacSweers
test file cleanups
e419f7c
@ZacSweers
Fix plugin toolchain
8804bcd
@ZacSweers
Update deps
511af27
@ZacSweers
inline away minifiertype
0148e20
@ZacSweers
Formatting + always emit diagnostics in tests
e6e55e2
@ZacSweers
Fix missing classpath wiring in test jar
3e315c0
@ZacSweers
ABI
ec1bbca
@ZacSweers
set toolchains and compilerOptions
4023ca2
@ZacSweers
More compilerOptions
542deeb
@ZacSweers
subprojects only
63391c5
@ZacSweers
...unfiltered?
2096a50
@ZacSweers
Use provider
988f943
@ZacSweers
Consolidate repositories
bc327c3
@ZacSweers
Trim comparison
3b47441
@ZacSweers
Copy link
Collaborator Author

oh my god it's working

@ZacSweers ZacSweers marked this pull request as ready for review February 24, 2023 22:42
@ZacSweers
Copy link
Collaborator Author

ZacSweers commented Mar 1, 2023 •
edited

I've published a 0.14.0-alpha04 with the changed up to this point in the PR

@alexvanyo alexvanyo mentioned this pull request Apr 2, 2023
Closed
@ZacSweers ZacSweers merged commit 5b9d59c into main Apr 15, 2023
3 checks passed
@ZacSweers ZacSweers deleted the z/agp8 branch April 15, 2023 21:52
@ZacSweers
Copy link
Collaborator Author

So much better

Screenshot 2023-04-15 at 10 37 57 PM

@alexvanyo alexvanyo mentioned this pull request Feb 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeraz valeraz valeraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClassNotFoundException for MultipleArtifact.ALL_CLASSES_DIR with AGP 8.0.0-alpha09
2 participants
@ZacSweers @valeraz