Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README and restart burst limit to service file #583

Closed
wants to merge 1 commit into from

Conversation

tarrenj
Copy link

@tarrenj tarrenj commented Nov 12, 2021

Add a 30 second delay before restarting the service after a failure and
prevents additional restarts after 5 attempts.

Add some basic usage/installation instructions for the Systemd service
file to the README.md within the example service file directory.

Change After= to nss-lookup for when hostnames are in the nebula config file.

@tarrenj
Copy link
Author

tarrenj commented Nov 12, 2021

This is a continuation/resolution of #580.

Add a 30 second delay before restarting the service after a failure and
prevents additional restarts after 5 attempts.

Add some basic usage/installation instructions for the Systemd service
file to the README.md within the example service file directory.

Change `After=` to nss-lookup for when hostnames are in the nebula config file and change `Wants=` to network-online
@tarrenj
Copy link
Author

tarrenj commented Nov 15, 2021

Also see #522, waiting for nss-lookup.target will ensure hostnames resolve before Nebula starts up.

@johnmaguire johnmaguire mentioned this pull request Apr 1, 2024
@johnmaguire
Copy link
Collaborator

I don't think we should recommend copying the systemd unit to /lib - that's where system-installed scripts go. User-installed ones belong in /etc. :)

I think also we do not need the TODO bit about initd in the README. I'd maybe eschew the README altogether as we really prefer people install from their system package manager if possible. For users who have other goals, we kind of expect they know how to install service files, or can figure it out.

The other systemd unit file changes are more interesting, and possibly worth considering. Maybe you can update the PR to just include those changes?

@johnmaguire
Copy link
Collaborator

The most important changes seem to have already landed: https://github.com/slackhq/nebula/blob/master/examples/service_scripts/nebula.service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants