Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to build all windows-arm64 / bin-windows-arm64 build option #638

Merged
merged 3 commits into from Mar 18, 2022

Conversation

bitshop
Copy link
Contributor

@bitshop bitshop commented Feb 15, 2022

Simple change to build for Windows on ARM64 - I did limited testing using my Surface Pro X.

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2022

CLA assistant check
All committers have signed the CLA.

@wadey
Copy link
Member

wadey commented Mar 18, 2022

I updated your PR to also generate release binaries for windows-arm64. Is there any way you can test nebula-windows-arm64.zip from this test release:

Thanks!

@wadey wadey added this to the v1.6.0 milestone Mar 18, 2022
@bitshop
Copy link
Contributor Author

bitshop commented Mar 18, 2022

I have tested on my Surface Pro X and the build works perfect! Thank you.

@wadey wadey added windows needs-changelog We merged, but still need to write a CHANGELOG entry labels Mar 18, 2022
Copy link
Member

@wadey wadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a test release and it works, thank you!

(I changed it to bin-windows-arm64 for consistency)

@wadey wadey changed the title Add to build all windows-arm64 / bin-winarm64 build option Add to build all windows-arm64 / bin-windows-arm64 build option Mar 18, 2022
@wadey wadey merged commit 7672c70 into slackhq:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-changelog We merged, but still need to write a CHANGELOG entry windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants