Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and test with go1.18 #656

Merged
merged 2 commits into from Apr 5, 2022
Merged

build and test with go1.18 #656

merged 2 commits into from Apr 5, 2022

Conversation

wadey
Copy link
Member

@wadey wadey commented Mar 17, 2022

Don't upgrade the go.mod version yet, but at least start building and
testing with go1.18

- https://go.dev/doc/go1.18
@johnmaguire
Copy link
Collaborator

A go directive indicates that a module was written assuming the semantics of a given version of Go. The version must be a valid Go release version: a positive integer followed by a dot and a non-negative integer (for example, 1.9, 1.14).

https://go.dev/ref/mod#go-mod-file-go

Given the new support for generics as well as changes to /x/sys, if developers & CI are running with go1.18, perhaps the go.mod should be bumped as well?

@wadey
Copy link
Member Author

wadey commented Mar 18, 2022

Given the new support for generics as well as changes to /x/sys, if developers & CI are running with go1.18, perhaps the go.mod should be bumped as well?

I don't see a good reason not to, so let's go ahead and do that. Updated the PR.

@wadey wadey added this to the v1.6.0 milestone Apr 5, 2022
@wadey wadey merged commit 3913062 into master Apr 5, 2022
@wadey wadey deleted the go1.18 branch April 5, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants