Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit certificate.ttl_seconds metric #782

Merged
merged 2 commits into from Apr 4, 2023
Merged

emit certificate.ttl_seconds metric #782

merged 2 commits into from Apr 4, 2023

Conversation

wadey
Copy link
Member

@wadey wadey commented Nov 23, 2022 •
edited

This change emits a gauge metric indicating how much time until the certificate expires. The value will go negative once the certificate has expired.

I welcome feedback on the metric name, perhaps certificate.expiration_seconds would be better?

@wadey wadey added this to the v1.7.0 milestone Nov 23, 2022
@wadey wadey added the enhancement New feature or request label Nov 23, 2022
@johnmaguire
Copy link
Collaborator

johnmaguire commented Dec 7, 2022 •
edited

This PR solves #608. There is some prior art located at #613 as well as #138.

@nbrownus
Copy link
Collaborator

Yeah I think certificate.expiration_seconds or certificate.ttl_seconds is a bit cleaner than certificate.expiration_ttl_seconds

@wadey wadey self-assigned this Mar 27, 2023
@nbrownus nbrownus added the needs-defined-net-review Review needed from a Defined Networking team member label Mar 29, 2023
wadey and others added 2 commits April 3, 2023 20:02
@wadey @nbrownus
emit certificate.expiration_ttl_seconds metric
08958bf 
This change emits a gauge metric indicating how much time until the
certificate expires. The value will go negative once the certificate has
expired.
@nbrownus
Update metric name
75648e1
@nbrownus nbrownus dismissed a stale review via 75648e1 April 4, 2023 01:04
@nbrownus nbrownus force-pushed the certificate-expiration-metric branch from 16f8e40 to 75648e1 Compare April 4, 2023 01:04
@nbrownus nbrownus merged commit 6685856 into master Apr 4, 2023
6 checks passed
@nbrownus nbrownus deleted the certificate-expiration-metric branch April 4, 2023 01:18
@johnmaguire johnmaguire mentioned this pull request Apr 4, 2023
Closed
@wadey wadey changed the title emit certificate.expiration_ttl_seconds metric emit certificate.ttl_seconds metric May 10, 2023
gabos31 pushed a commit to oneclick-ag/nebula that referenced this pull request Jul 4, 2023
@wadey
emit certificate.expiration_ttl_seconds metric (slackhq#782)
8ba38b1
@johnmaguire johnmaguire mentioned this pull request Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbrownus nbrownus nbrownus approved these changes

Assignees

@wadey wadey

Labels
enhancement New feature or request needs-defined-net-review Review needed from a Defined Networking team member
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wadey @johnmaguire @nbrownus