log network as String to match the other log event that emits network #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabos31
pushed a commit
to oneclick-ag/nebula
that referenced
this pull request
Jul 4, 2023
…at emits network (slackhq#811) Co-authored-by: Tricia Bogen <tbogen@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Small change for consistency in structured logging. We have two log calls that emit a
networkfield. Currently one of them is a String and the other one is the object itself (which gets encoded as a JSON object for JSON logging). This changes the latter call to emit a String.Happy to go the other direction, too, if we think that's better, but I'll note that the structure of
Maskin the resulting log entry is not super great (at least after logstash is done with it):{"IP": "10.219.11.104", "Mask": "/4AAAA=="}