Allow listen.host to contain names
#825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasikpark
reviewed
Mar 15, 2023
| @@ -107,7 +107,7 @@ lighthouse: | |||
| # Port Nebula will be listening on. The default here is 4242. For a lighthouse node, the port should be defined, | |||
| # however using port 0 will dynamically assign a port and is recommended for roaming nodes. | |||
| listen: | |||
| # To listen on both any ipv4 and ipv6 use "[::]" | |||
There was a problem hiding this comment.
ohh I guess this is the zero syntax w/o a port number, but the [ and ] are optional?
| listenHost = &net.IPAddr{IP: net.IPv6zero} | ||
|
|
||
| } else { | ||
| listenHost, err = net.ResolveIPAddr("ip", rawListenHost) |
There was a problem hiding this comment.
https://pkg.go.dev/net#ResolveIPAddr
The address parameter can use a host name, but this is not recommended, because it will return at most one of the host name's IP addresses.
I guess that doesn't matter?
| lc := NewListenConfig(multi) | ||
| pc, err := lc.ListenPacket(context.TODO(), "udp", fmt.Sprintf("%s:%d", ip, port)) | ||
| pc, err := lc.ListenPacket(context.TODO(), "udp", net.JoinHostPort(ip.String(), fmt.Sprintf("%v", port))) |
There was a problem hiding this comment.
commenting these function docs for my own understanding, sorry if this is too much:
wadey
approved these changes
Apr 5, 2023
|
any docs on this feature to add to https://nebula.defined.net? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some networks (like fly.io, DO) it is desirable to listen on specific address and the easiest way to discover that address is by using a known name.
Closes #817