Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-15.0: backport required Transaction Throttler PRs, pt. 4 #371

Merged
merged 4 commits into from
May 28, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented May 27, 2024

Description

Backports:

  1. Skip recalculating the rate in MaxReplicationLagModule when it can't be done vitessio/vitess#12620
  2. Throttled transactions return MySQL error code 1041 ER_OUT_OF_RESOURCES vitessio/vitess#12949
  3. MaxReplicationLagModule.recalculateRate no longer fills the log vitessio/vitess#14875

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

…be done (vitessio#12620)

* Skip recalculating the rate in MaxReplicationLagModule when it can't be done

This defends against lag records with nil stats which can lead to segfaults.
See vitessio#12619

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

* Address PR comments.

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

* Make linter happy

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

---------

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
…ES (vitessio#12949)

This error code seems better suited to represent the fact that transactions are
being throttled by the server due to some form of resource contention than the
current code 1203 ER_TOO_MANY_USER_CONNECTIONS.

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
…ssio#14875)

Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
@github-actions github-actions bot added this to the v15.0.5 milestone May 27, 2024
@timvaillancourt timvaillancourt marked this pull request as ready for review May 27, 2024 14:31
@timvaillancourt timvaillancourt requested a review from a team as a code owner May 27, 2024 14:31
@timvaillancourt timvaillancourt merged commit a3c6f97 into slack-15.0 May 28, 2024
122 of 194 checks passed
@timvaillancourt timvaillancourt deleted the bp-txthrottler-pt4-slack-15.0 branch May 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants