Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-15.0: Add timeout to all the contexts used for RPC calls in vtorc (#15991) #405

Merged
merged 4 commits into from
Jun 10, 2024
Merged

slack-15.0: Add timeout to all the contexts used for RPC calls in vtorc (#15991) #405

merged 4 commits into from
Jun 10, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Jun 7, 2024 •
edited
Loading

Description

Backports vitessio#15991 from v20

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

GuptaManan100 and others added 2 commits June 7, 2024 22:31
@GuptaManan100 @timvaillancourt
Add timeout to all the contexts used for RPC calls in vtorc (vitessio…
dfc4e87 
…#15991)

Signed-off-by: Manan Gupta <manan@planetscale.com>
@timvaillancourt
add context that didn't merge well
90bbdc4 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@salesforce-cla Salesforce CLA
Copy link

salesforce-cla bot commented Jun 7, 2024

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone Jun 7, 2024
@timvaillancourt
revert unneeded tm_client.go change
2d44fa1 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt marked this pull request as ready for review June 7, 2024 20:44
@timvaillancourt timvaillancourt requested a review from a team as a code owner June 7, 2024 20:44
@timvaillancourt timvaillancourt merged commit 0474726 into slack-15.0 Jun 10, 2024
193 of 194 checks passed
@timvaillancourt timvaillancourt deleted the bp-pr15991-slack-15.0 branch June 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees
No one assigned
Labels
cla:missing upstream-backport An upstream backport v15 v20-backport vtorc
Projects
None yet
Milestone
v15.0.5
3 participants
@timvaillancourt @tanjinx @GuptaManan100