slack-15.0: reset semi-sync in setReplicationSourceRepairReplication
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
This reverts commit e67be76.
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
previously approved these changes
Jul 9, 2024
vmogilev
reviewed
Jul 9, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in an internal thread, this PR causes
setReplicationSourceRepairReplicationto reset semi-sync if required. This does not happen in v15 because VTOrc became GA, however, at least temporarily we need the v14 behaviour that this PR restoresThis is a one-time patch that will not carry forward to other releases
Finally, the CI failed on installing
percona-xtrabackup-24(unrelated to this PR) due to changes in the Percona repo. Error wasE: Unable to locate package percona-xtrabackup-24. This was fixed here to unblock the CIcc @ejortegau
Related Issue(s)
Checklist
Deployment Notes