rework tabletbalancer interface to avoid unnecessary sort #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demmer
force-pushed
the
tabletbalancer-pick-one
branch
2 times, most recently
from
6021332
to
577377d
Compare
There's actually no need in the tabletgateway to ever sort the full list of potential tablet candidates, because each query attempt only goes to a single tablet, and then if that fails, the withRetry loop records which tablet failed and then re-enters the loop to try again. Therefore, refactor the balancer to replace ShuffleTablets with a simple Pick interface that just returns the best tablet to route to.
demmer
force-pushed
the
tabletbalancer-pick-one
branch
from
577377d
to
308d7c8
Compare
venkatraju
approved these changes
Jul 8, 2024
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework the tabletbalancer interface to avoid an unnecessary sort.
There's actually no need in the tabletgateway to ever sort the full list of potential tablet candidates, because each query attempt only goes to a single tablet, and then if that fails, the withRetry loop records which tablet failed and then re-enters the loop to try again.
Therefore, refactor the balancer to replace ShuffleTablets with a simple Pick interface that just returns the best tablet to route to.
Related Issue(s)
Checklist
Deployment Notes