Notify reporter when compilation fails

[glenjamin]

I'm currently working on updating speclj-growl to work with the latest version of clojure/speclj, I've got it working but I've got a downstream dependency i've submitted a patch for before I can publish.

One thing that I think would be useful for a plugin like this, is to be notified when a compilation error occurs - at the moment it just goes quiet when there's a problem and you're left to tab back to the terminal to find out what's going on.

I'll probably have a go at putting together a patch for this in the next week or so if no-one else gets to it first.

[slagyr]

Capturing compile errors is an insightful request. It would be great to have a patch that passed compile errors to the reporters.

[glenjamin]

I wasn't sure whether the built-in reporters should react to this new message, so I left the existing behaviour intact.

Any third party formatters would have add the new method stub after this change - as far as I can tell the only alternative is making the extra method part of a new protocol

[glenjamin]

Any word on this? Is there some stuff missing before it could get checked in, or is it just a time issue?

[slagyr]

Glen,

I'm sorry. I didn't realize you were waiting for a response.

So if you add a new function to the Reporter protocol, existing 3rd party reporters will break…. Well, fortunately there aren't many out there. And they'd only be broken for new releases of Speclj. So I'd be in favor of keeping things simple and adding the new function to the Rerporter protocol.

On Apr 20, 2013, at 6:56 PM, Glen Mailer notifications@github.com wrote:

Any word on this? Is there some stuff missing before it could get checked in, or is it just a time issue?

—
Reply to this email directly or view it on GitHub.

[glenjamin]

Ok, sounds good - I sneakily changed this issue into a pull request, so it should now be good to merge.

[slagyr]

This is great! Thanks. A new release should be out soon with this included.