fixes tableau port delimiter: ":" vs "-" (#114)

slalom · Jul 14, 2020 · 12d423b · 12d423b
1 parent e5adcfd
commit 12d423b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/catalog/aws/tableau-server/main.tf b/catalog/aws/tableau-server/main.tf
@@ -39,6 +39,8 @@ locals {
     "Tableau License Verification Service" = "27000:27009"
     "Tableau dynamic process mapping"      = "8000:9000"
   }
+  # Allow cluster to communicate with itself on all ports.
+  # At minimum, ports 8000:9000 are required.
   cluster_ports = merge(local.tableau_app_ports, local.tableau_admin_ports)
 }
 

diff --git a/components/aws/ec2/main.tf b/components/aws/ec2/main.tf
@@ -123,8 +123,8 @@ resource "aws_security_group" "ecs_cluster_traffic" {
       description = egress.key
       self        = true
       protocol    = "tcp"
-      from_port   = split("-", egress.value)[0]
-      to_port     = reverse(split("-", egress.value))[0]
+      from_port   = split(":", egress.value)[0]
+      to_port     = reverse(split(":", egress.value))[0]
     }
   }
   dynamic "ingress" {
@@ -133,8 +133,8 @@ resource "aws_security_group" "ecs_cluster_traffic" {
       description = ingress.key
       self        = true
       protocol    = "tcp"
-      from_port   = split("-", ingress.value)[0]
-      to_port     = reverse(split("-", ingress.value))[0]
+      from_port   = split(":", ingress.value)[0]
+      to_port     = reverse(split(":", ingress.value))[0]
     }
   }
 }