Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
davenicoll committed Jun 24, 2023
1 parent f30018f commit dcb9e24
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker-build-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ jobs:
test-full-alpine:
name: Test full-alpine-amd64
runs-on: alpine-latest
runs-on: ubuntu-latest
container:
image: ghcr.io/slalombuild/pe-toolkit-full-alpine-amd64:1.0.${{ github.run_number }}
credentials:
Expand Down
15 changes: 14 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,20 @@ Sure, go ahead and submit a PR. Some considerations when adding a tool -
- If the tool significantly increases the image size, is it something we want in our toolkit, or something we'd run in a pipeline using an official image for the tool?
- Standard is intended to be lightweight, mainly used in pipelines, and Full is intended for development environments

#### Which versions do we use?
#### I've made some changes and they don't work, how do I debug the problem?

1. Attempt to build the problematic image. Change to the relevant folder containing a `Dockerfile` under `images` and run
```bash
docker build -t test:latest .
```
2. View the output for any errors.
3. If the container image builds successfully, start a shell in the container using
```bash
docker run --rm -it --entrypoint /bin/bash test
```
and perform further debugging steps.

#### Which versions of binaries do we use?

We use the latest version of each tool at the time of building of the image.

Expand Down

0 comments on commit dcb9e24

Please sign in to comment.