Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure tokens so they cannot be printed to Actions console output by any user with access to run GH Actions. #275

Closed
chrisba11 opened this issue Aug 15, 2023 · 1 comment · Fixed by #276
Assignees
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code

Comments

@chrisba11
Copy link
Contributor

chrisba11 commented Aug 15, 2023

As a security engineer, I want to restrict the use of secret access tokens to workflows running on the main branch in order to ensure that this project is not vulnerable to exposing those secrets in the GH Actions workflows run by contributors.

Technical Notes

Currently, any user who has the permission to run a GH Action has the ability to echo out the personal access tokens or GH App tokens we are using for publishing. We should be able to resolve this by moving all jobs that require use of these tokens to a standalone workflow that can only be triggered by push to the main branch. I believe we will have to move any related secrets to a protected environment that can only be accessed from the main branch as well.

Acceptance Criteria

  1. Developers on a feature branch cannot push code that has access to the actions-helper GH app token.
@chrisba11 chrisba11 added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Aug 15, 2023
@chrisba11
Copy link
Contributor Author

Once this is merged in and functionality is confirmed, we will need to delete the org secret called ACTIONHELPER.

chrisba11 added a commit that referenced this issue Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant