Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename integration-test folder to smoke-test (only if history can be preserved) #437

Closed
JordoHeffernan opened this issue Feb 13, 2024 · 1 comment · Fixed by #525
Closed

Rename integration-test folder to smoke-test (only if history can be preserved) #437

JordoHeffernan opened this issue Feb 13, 2024 · 1 comment · Fixed by #525
Assignees
@rt-slalom
Labels
chore Work that provides indirect value testing Bulk of this work is writing or updating unit/smoke tests

Comments

@JordoHeffernan
Copy link
Contributor

JordoHeffernan commented Feb 13, 2024 •
edited
Loading

As a secureli maintainer I don't love that our smoke tests are called integrations tests

AC

  1. Change the folder name integration tests to smoke tests
  2. Only do this if we can preserve in some way our existing GitHub integration tests history (lives in Actions)
@JordoHeffernan JordoHeffernan added chore Work that provides indirect value testing Bulk of this work is writing or updating unit/smoke tests labels Feb 13, 2024
@rt-slalom rt-slalom self-assigned this Apr 18, 2024
@rt-slalom rt-slalom linked a pull request Apr 19, 2024 that will close this issue
chore: change workflow name #525
Merged
8 tasks
@rt-slalom
Copy link
Contributor

rt-slalom commented Apr 19, 2024 •
edited
Loading

Here's some Post merge test evidence:

New Smoke Testing Workflow created
Image

stage renamed in Publish workflow
Image

historical integration testing maintained in older publishing runs
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt-slalom rt-slalom

Labels
chore Work that provides indirect value testing Bulk of this work is writing or updating unit/smoke tests
Projects
seCureLI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: change workflow name slalombuild/secureli
2 participants
@JordoHeffernan @rt-slalom