Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change workflow name #525

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

rt-slalom
Copy link
Contributor

secureli-437

Changes the name of the integration test workflow to smoke test.
According to the issue raised on stack overflow here, and the github documentation here, the old integration test workflow history should remain. Workflow runs must be deleted manually, and renaming the files should create a new workflow.

If the Integration Test workflow is still active after this PR is merged, it should be disabled. How to disable a workflow

Changes

  • Rename .github/workflows/integration_testing.yml to .github/workflows/smoke_testing.yml
  • Updated workflow name to Smoke Testing
  • Updated job name and file reference to Smoke Testing in .github/workflows/publish.yml

Testing

  • Not sure how to test, since this workflow will only run on main and be created when this PR is merged.

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

@rt-slalom rt-slalom merged commit be4a1af into main Apr 19, 2024
5 checks passed
@rt-slalom rt-slalom deleted the feature/secureli-437-rename-integration-test-folder branch April 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename integration-test folder to smoke-test (only if history can be preserved)
3 participants