Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add GitPython to dependencies list #530

Merged

Conversation

rt-slalom
Copy link
Contributor

secureli-526

Add the GitPython package to our list of dependencies so that Poetry adds it on install.

Changes

  • add gitpython to pyproject.toml
  • regenerated lock file with updated gitpython version
  • poetry install also made some updates to the extra optional dependencies in the lock file

Testing

Ran Secureli init after a clean install, it passed

Screenshot 2024-04-23 at 3 44 54 PM

Ran Poe Tests
Screenshot 2024-04-23 at 3 45 29 PM

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

@rt-slalom rt-slalom marked this pull request as ready for review April 23, 2024 19:56
@rt-slalom rt-slalom linked an issue Apr 23, 2024 that may be closed by this pull request
Copy link
Contributor

@isaac-heist-slalom isaac-heist-slalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rt-slalom rt-slalom merged commit ac354ba into main Apr 24, 2024
9 of 11 checks passed
@rt-slalom rt-slalom deleted the fix/secureli-526-bug-investigate-modulenotfounderror branch April 24, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Investigate ModuleNotFoundError
2 participants