Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prompted to ReInstall When Running on Branch #545

Merged
merged 3 commits into from
May 10, 2024

Conversation

isaac-heist-slalom
Copy link
Contributor

secureli-537

Fixed bug that says "seCureLI is installed and up-to-date for the following language(s)", even though seCureLI is not initialized completely in that branch. This is an edge case where seCureLI has been installed on one branch, but not on the other branch in the same directory due to seCureLI artifacts that are git ignored.

Changes

  • Added messaging and stop of secureli process when this edge case occurs.
  • Updated detect-secret hook version

Testing

  • Added required tests
  • All existing tests are passing

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

@isaac-heist-slalom isaac-heist-slalom linked an issue May 9, 2024 that may be closed by this pull request
@isaac-heist-slalom isaac-heist-slalom marked this pull request as ready for review May 10, 2024 17:50
@isaac-heist-slalom isaac-heist-slalom merged commit 22bbc35 into main May 10, 2024
5 checks passed
@isaac-heist-slalom isaac-heist-slalom deleted the feature/secureli-537-prompted-to-reinstall branch May 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompted to ReInstall When Running on Branch
2 participants