Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Precommit config overwritten on init #572

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

itoltz
Copy link
Contributor

@itoltz itoltz commented Jun 17, 2024

secureli-570

An existing precommit config file will be overwritten when running secureli init.

I've added a flag to the init action to prevent overwriting the config-- `secureli init --preserve-precommit-config'

Changes

  • Added --preserve-precommit-config parameter to init action

Testing

  • Added copy of existing test with the flag added

Clean Code Checklist

  • Meets acceptance criteria for issue
  • New logic is covered with automated tests
  • Appropriate exception handling added
  • Thoughtful logging included
  • Documentation is updated
  • Follow-up work is documented in TODOs
  • TODOs have a ticket associated with them
  • No commented-out code included

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match (chore|style|test|feat|fix|docs|ci): .+

@itoltz itoltz changed the title bug: Precommit config overwritten on init fix: Precommit config overwritten on init Jun 17, 2024
@github-actions github-actions bot dismissed their stale review June 17, 2024 18:50

All good!

.secureli.yaml Outdated Show resolved Hide resolved
Some bad data got added to this file
@itoltz itoltz merged commit f818123 into main Jun 20, 2024
5 checks passed
@itoltz itoltz deleted the bug/secureli-570-overwrite-config-on-init-bug branch June 20, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants