chore: updatehooks skips updated repos that aren't out of date by default #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for non out-of-date repos are done
…eature/secureli-434-check-for-updates-in-pre-commit-before-forcing-update-regardless-of-need
itoltz
approved these changes
Jun 20, 2024
added 8 commits
June 21, 2024 12:17
shrutitirpude
approved these changes
Jun 26, 2024
ian-bowden-slalom
deleted the
feature/secureli-434-check-for-updates-in-pre-commit-before-forcing-update-regardless-of-need
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new argument to the updatehooks function named force_update which is set to False by default. if force_update is false, then we won't download/install the repo unless it is out of date. If force_update is True, then we'd download and install the latest repo version irrespective of the currently installed version.
There is currently no code (outside of unit tests) that's passing True for the force_update argument.
Changes
Testing
Clean Code Checklist