update for halogen1.0.0 #20
Conversation
There was a problem hiding this comment.
Would like to see what you think about that dimensions thing before merging. The rest looks good though!
I think the package.json will need updating with an -- for the psa arguments too, Travis is failing before that even due to the halogen dependency mismatch.
example/src/Main.purs
Outdated
| @@ -65,12 +67,10 @@ render state = | |||
| where | |||
| renderOne ix = | |||
| HH.div | |||
| [ HP.key ("echarts-" <> show ix) ] | |||
| [ ] | |||
There was a problem hiding this comment.
Minorest of nitpicks: could use div_ here 😄
src/Halogen/ECharts.purs
Outdated
| ∷ ∀ eff g i r | ||
| . (MonadAff (EChartsEffects eff) g) | ||
| ⇒ (i → Maybe (EChartsQuery Unit)) | ||
| → { width ∷ Int, height ∷ Int | r } |
There was a problem hiding this comment.
Maybe we should make the dimensions the input value for the component? Seems like a prime candidate for where that kind of thing would be great. The parameterised input thing here is pretty cool, but I think dimensions is by far the most useful possible thing we could use i for (it was actually the motivating case for why I added inputs to this release) - manual querying seems more appropriate for updating with new data, etc.
I guess we could do a mixture of the two, if we used Tuple Dimensions i -> ... perhaps?
cryogenian
force-pushed
the
halogen-1.0.0
branch
2 times, most recently
from
8739583
to
93c3e25
Compare
|
cryogenian
force-pushed
the
halogen-1.0.0
branch
from
93c3e25
to
4ea11f8
Compare
Depends on purescript-halogen/purescript-halogen-css#15
@garyb please review