Skip to content

Commit

Permalink
Optimizations
Browse files Browse the repository at this point in the history
  • Loading branch information
@sv2
sv2 committed Sep 13, 2019
1 parent 6c7880b commit 9291569
Show file tree
Hide file tree
Showing 3 changed files with 232 additions and 261 deletions.
317 changes: 117 additions & 200 deletions lib/swsCoreStats.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,234 +13,151 @@ const swsMetrics = require('./swsmetrics');
const swsUtil = require('./swsUtil');
const SwsReqResStats = require('./swsReqResStats');

// Constructor
function swsCoreStats() {

// Options
this.options = null;
/* swagger=stats Prometheus metrics */
class SwsCoreStats {

// Timestamp when collecting statistics started
this.startts = Date.now();
constructor(){

// Statistics for all requests
this.all = null;
// Timestamp when collecting statistics started
this.startts = Date.now();

// Statistics for requests by method
// Initialized with most frequent ones, other methods will be added on demand if actually used
this.method = null;
// Statistics for all requests
this.all = null;

// System statistics
this.sys = null;
// Statistics for requests by method
// Initialized with most frequent ones, other methods will be added on demand if actually used
this.method = null;

// CPU
this.startTime = null;
this.startUsage = null;

// Array with last 5 hrtime / cpuusage, to calculate CPU usage during the last second sliding window ( 5 ticks )
this.startTimeAndUsage = null;
// Prometheus metrics
this.promClientMetrics = {};
}

// Prometheus metrics
this.promClientMetrics = {};
}
// Initialize
initialize() {

// Initialize
swsCoreStats.prototype.initialize = function (swsOptions) {
// Statistics for all requests
this.all = new SwsReqResStats(swsSettings.apdexThreshold);

this.options = swsOptions;
// Statistics for requests by method
// Initialized with most frequent ones, other methods will be added on demand if actually used
this.method = {
'GET': new SwsReqResStats(swsSettings.apdexThreshold),
'POST': new SwsReqResStats(swsSettings.apdexThreshold),
'PUT': new SwsReqResStats(swsSettings.apdexThreshold),
'DELETE': new SwsReqResStats(swsSettings.apdexThreshold)
};

// Statistics for all requests
this.all = new SwsReqResStats(this.options.apdexThreshold);
// metrics
swsMetrics.clearPrometheusMetrics(this.promClientMetrics);

// Statistics for requests by method
// Initialized with most frequent ones, other methods will be added on demand if actually used
this.method = {
'GET': new SwsReqResStats(this.options.apdexThreshold),
'POST': new SwsReqResStats(this.options.apdexThreshold),
'PUT': new SwsReqResStats(this.options.apdexThreshold),
'DELETE': new SwsReqResStats(this.options.apdexThreshold)
this.promClientMetrics = swsMetrics.getPrometheusMetrics(swsSettings.metricsPrefix,swsMetrics.coreMetricsDefs);
};

// System statistics
this.sys = {
rss: 0,
heapTotal: 0,
heapUsed: 0,
external: 0,
cpu: 0
// TODO event loop delays
getStats() {
return { startts: this.startts, all: this.all };
};

// CPU
this.startTime = process.hrtime();
this.startUsage = process.cpuUsage();

// Array with last 5 hrtime / cpuusage, to calculate CPU usage during the last second sliding window ( 5 ticks )
this.startTimeAndUsage = [
{ hrtime: process.hrtime(), cpuUsage: process.cpuUsage() },
{ hrtime: process.hrtime(), cpuUsage: process.cpuUsage() },
{ hrtime: process.hrtime(), cpuUsage: process.cpuUsage() },
{ hrtime: process.hrtime(), cpuUsage: process.cpuUsage() },
{ hrtime: process.hrtime(), cpuUsage: process.cpuUsage() }
];

// metrics
swsMetrics.clearPrometheusMetrics(this.promClientMetrics);

this.promClientMetrics = swsMetrics.getPrometheusMetrics(swsSettings.metricsPrefix,swsMetrics.coreMetricsDefs);

// TODO Move to swsSystemStats
this.promClientMetrics = Object.assign(
{},
this.promClientMetrics,
swsMetrics.getPrometheusMetrics(swsSettings.metricsPrefix,swsMetrics.systemMetricsDefs)
);

};

swsCoreStats.prototype.getStats = function () {
return { startts: this.startts, all: this.all, sys: this.sys };
};

swsCoreStats.prototype.getMethodStats = function () {
return this.method;
};


// Update timeline and stats per tick
swsCoreStats.prototype.tick = function (ts,totalElapsedSec) {

// Rates
this.all.updateRates(totalElapsedSec);
for( var method in this.method) {
this.method[method].updateRates(totalElapsedSec);
}

// System stats
this.calculateSystemStats(ts,totalElapsedSec);
};

// Calculate and store system statistics
swsCoreStats.prototype.calculateSystemStats = function(ts,totalElapsedSec) {

// Memory
var memUsage = process.memoryUsage();

// See https://stackoverflow.com/questions/12023359/what-do-the-return-values-of-node-js-process-memoryusage-stand-for
// #22 Handle properly if any property is missing
this.sys.rss = 'rss' in memUsage ? memUsage.rss : 0;
this.sys.heapTotal = 'heapTotal' in memUsage ? memUsage.heapTotal : 0;
this.sys.heapUsed = 'heapUsed' in memUsage ? memUsage.heapUsed : 0;
this.sys.external = 'external' in memUsage ? memUsage.external : 0;

var startTU = this.startTimeAndUsage.shift();

var cpuPercent = swsUtil.swsCPUUsagePct(startTU.hrtime, startTU.cpuUsage);

this.startTimeAndUsage.push( { hrtime: process.hrtime(), cpuUsage: process.cpuUsage() } );

//this.startTime = process.hrtime();
//this.startUsage = process.cpuUsage();

this.sys.cpu = cpuPercent;

// Update prom-client metrics
this.promClientMetrics.nodejs_process_memory_rss_bytes.set(this.sys.rss);
this.promClientMetrics.nodejs_process_memory_heap_total_bytes.set(this.sys.heapTotal);
this.promClientMetrics.nodejs_process_memory_heap_used_bytes.set(this.sys.heapUsed);
this.promClientMetrics.nodejs_process_memory_external_bytes.set(this.sys.external);
this.promClientMetrics.nodejs_process_cpu_usage_percentage.set(this.sys.cpu);
};

// Count request
swsCoreStats.prototype.countRequest = function (req, res) {

// Count in all
this.all.countRequest(req.sws.req_clength);
getMethodStats() {
return this.method;
};

// Count by method
var method = req.method;
if (!(method in this.method)) {
this.method[method] = new SwsReqResStats();
}
this.method[method].countRequest(req.sws.req_clength);
// Update timeline and stats per tick
tick(ts,totalElapsedSec) {
// Rates
this.all.updateRates(totalElapsedSec);
for( let method of Object.keys(this.method)) {
this.method[method].updateRates(totalElapsedSec);
}
};

// Update prom-client metrics
this.promClientMetrics.api_all_request_total.inc();
this.promClientMetrics.api_all_request_in_processing_total.inc();
req.sws.inflightTimer = setTimeout(function() {
this.promClientMetrics.api_all_request_in_processing_total.dec();
}.bind(this), 250000);
};
// Count request
countRequest(req) {

// Count in all
this.all.countRequest(req.sws.req_clength);

// Count finished response
swsCoreStats.prototype.countResponse = function (res) {
// Count by method
var method = req.method;
if (!(method in this.method)) {
this.method[method] = new SwsReqResStats();
}
this.method[method].countRequest(req.sws.req_clength);

// Update prom-client metrics
this.promClientMetrics.api_all_request_total.inc();
this.promClientMetrics.api_all_request_in_processing_total.inc();
req.sws.inflightTimer = setTimeout(function() {
this.promClientMetrics.api_all_request_in_processing_total.dec();
}.bind(this), 250000);
};

var req = res._swsReq;
countResponse (res) {

// Defaults
var startts = 0;
var duration = 0;
var resContentLength = 0;
var timelineid = 0;
var path = req.sws.originalUrl;
var req = res._swsReq;

// TODO move all this to Processor, so it'll be in single place
// Defaults
var startts = 0;
var duration = 0;
var resContentLength = 0;
var timelineid = 0;
var path = req.sws.originalUrl;

// TODO move all this to Processor, so it'll be in single place

if ("_contentLength" in res && res['_contentLength'] !== null ){
resContentLength = res['_contentLength'];
}else{
// Try header
if(res.getHeader('content-length') !==null ) {
resContentLength = parseInt(res.getHeader('content-length'));
if ("_contentLength" in res && res['_contentLength'] !== null ){
resContentLength = res['_contentLength'];
}else{
// Try header
if(res.getHeader('content-length') !==null ) {
resContentLength = parseInt(res.getHeader('content-length'));
}
}
}

if("sws" in req) {
startts = req.sws.startts;
timelineid = req.sws.timelineid;
var endts = Date.now();
req['sws'].endts = endts;
duration = endts - startts;
req['sws'].duration = duration;
req['sws'].res_clength = resContentLength;
path = req['sws'].api_path;
clearTimeout(req.sws.inflightTimer);
}

// Determine status code type
var codeclass = swsUtil.getStatusCodeClass(res.statusCode);
if("sws" in req) {
startts = req.sws.startts;
timelineid = req.sws.timelineid;
var endts = Date.now();
req['sws'].endts = endts;
duration = endts - startts;
req['sws'].duration = duration;
req['sws'].res_clength = resContentLength;
path = req['sws'].api_path;
clearTimeout(req.sws.inflightTimer);
}

// update counts for all requests
this.all.countResponse(res.statusCode,codeclass,duration,resContentLength);
// Determine status code type
var codeclass = swsUtil.getStatusCodeClass(res.statusCode);

// Update method-specific stats
var method = req.method;
if (method in this.method) {
var mstat = this.method[method];
mstat.countResponse(res.statusCode,codeclass,duration,resContentLength);
}
// update counts for all requests
this.all.countResponse(res.statusCode,codeclass,duration,resContentLength);

// Update Prometheus metrics
switch(codeclass){
case "success":
this.promClientMetrics.api_all_success_total.inc();
break;
case "redirect":
// NOOP //
break;
case "client_error":
this.promClientMetrics.api_all_errors_total.inc();
this.promClientMetrics.api_all_client_error_total.inc();
break;
case "server_error":
this.promClientMetrics.api_all_errors_total.inc();
this.promClientMetrics.api_all_server_error_total.inc();
break;
}
this.promClientMetrics.api_all_request_in_processing_total.dec();
// Update method-specific stats
var method = req.method;
if (method in this.method) {
var mstat = this.method[method];
mstat.countResponse(res.statusCode,codeclass,duration,resContentLength);
}

};
// Update Prometheus metrics
switch(codeclass){
case "success":
this.promClientMetrics.api_all_success_total.inc();
break;
case "redirect":
// NOOP //
break;
case "client_error":
this.promClientMetrics.api_all_errors_total.inc();
this.promClientMetrics.api_all_client_error_total.inc();
break;
case "server_error":
this.promClientMetrics.api_all_errors_total.inc();
this.promClientMetrics.api_all_server_error_total.inc();
break;
}
this.promClientMetrics.api_all_request_in_processing_total.dec();
};
}

module.exports = swsCoreStats;
module.exports = SwsCoreStats;

0 comments on commit 9291569

Please sign in to comment.