When the app is opened by link, sometimes the last-viewed page is restored instead

[smichel17]

Steps to reproduce:

1. Open a link to a GitHub issue (let's call it #1)
   • Does not matter if the app is previously open, but it must be opened by link (to issue?).
2. Put Octodroid into the background (e.g. go home or switch apps)
   • App must remain running in the background (do not dismiss it from recent apps or close it using the back button)
3. Open a link to a different GitHub issue (#2)

Expected: App opens to issue #2
Actual: App just switches back to the previous view of issue #1

Easiest to reproduce accidentally if you have email notifications enabled.

I suspect the root cause is some Activity not handling the intent the same in its onCreate and onNewIntent callbacks.

[maniac103]

I suspect the root cause is some Activity not handling the intent the same in its onCreate and onNewIntent callbacks.

The only activity with non-default launch mode is the launcher activity, and with default launch mode one doesn't get onNewIntent.
The BrowseFilter activity, which does the link handling, just is a proxy, that is, keeps the intent flags it's launched with in the intent it then launches after resolving. That means task behavior depends on the launching app ... which is? ;-)

[maniac103]

Nvm, I can reproduce with the AOSP email app, Google Keep doesn't reproduce because it doesn't set FLAG_ACTIVITY_NEW_TASK.

[smichel17]

Thanks for the fix :) (and, my app was K-9 mail)