New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing a reaction does not work anymore #1179

Closed

Fs00 opened this issue Feb 12, 2022 · 0 comments

Contributor

Fs00 commented Feb 12, 2022 •

edited

In order to remove reactions, the app is using an endpoint that has been removed a few days ago by GH and that was deprecated since two years ago in favor of more specific endpoints.
Also, the app doesn't handle reaction removal failure properly: the UI behaves as if the removal succeeded by making the reaction disappear, but obviously after refreshing the reaction is still there.

Fs00 mentioned this issue

Add missing page query parameter to getReviewComments maniac103/GitHubSdk#12

Merged

maniac103 closed this as completed in

e0e3b24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment