Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZWNJ Replacement #122

Merged
merged 2 commits into from Feb 23, 2022
Merged

ZWNJ Replacement #122

merged 2 commits into from Feb 23, 2022

Conversation

sadeghi-aa
Copy link
Contributor

Replace spaces with ZWNJ (نیم‌فاصله) in j_weekdays_fa

Replace spaces with ZWNJ (نیم‌فاصله) in j_weekdays_fa
@slashmili
Copy link
Owner

Thanks @sadeghi-aa ❤️

I'm just wondering if we should worry about backward compatibility or not 🤔

@hramezani
Copy link
Collaborator

I think it is not a big change and hope it doesn't break anything.
BTW, we can add a change log and mention this on changelog before release

@hramezani hramezani merged commit fb6f4ed into slashmili:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants