Add ZoneInfo support. #93
Conversation
hramezani
force-pushed
the
zoneinfo
branch
2 times, most recently
from
c113065
to
ab03036
Compare
|
@hramezani do you think we should bump the major version? |
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## Unreleased | |||
There was a problem hiding this comment.
Sweet! Nice idea to keep track of changes 👏
Sure! Before release, do we want to drop support for Python < 3.6? |
|
TBH I don't know. What is wrong with Python < 3.6? |
Nothing, as Python < 3.6 no longer receives updates and most of python packages usually drop support for unsupported python versions, I would suggest dropping python < 3.6 support. If we want to drop the support we can postpone the release otherwise we can release now. |
|
@slashmili I would suggest first merging this PR and releasing a major version then we can think about dropping python < 3.6 support. I am going to make django-jalali compatible with Django 4.0 and this fix is needed there! |
There was a problem hiding this comment.
nice 👍
I don't see if we're breaking backward compatibility, so we can just increase the minor version.
I don't see the benefit of dropping older python versions now, we can keep them supported, until the day it becomes a burden (if at all), then we can increase major version and drop support for older versions.
|
Thanks @farzadghanei for the review.
I think there are some benefits like using new features in python(for example string formating). make development easier because you don't need to check multiple python version specifications. also, by dropping a python version support(for example 2.7) we will push users to upgrade to a newer python package which is good IMHO. and they still have the possibility to use the older version of this package which supports old python. |
|
@farzadghanei I merged the PR. Could you please make a new release? As I mentioned before, I need it for the |
The Python standard library’s zoneinfo is now the default timezone implementation in Django 4.0.
We need this change to make django-jalali compatible with Django 4.0