Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

allow for tracingInstrument and tracingInstrument(of: Type) APIs #101

Conversation

ktoso
Copy link
Collaborator

@ktoso ktoso commented Jul 30, 2020

No description provided.

Copy link
Owner

@slashmo slashmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I usually try to avoid exposing "non-public" public API like hell, but in this case it seems like a necessary trait-off.

@ktoso
Copy link
Collaborator Author

ktoso commented Jul 30, 2020

Applied feedback, ready to merge (into your PR)

@slashmo slashmo merged commit 6b64f9b into slashmo:refactor/tracing-instrumentation Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants