Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Add instructions to README 📖 #139

Merged
merged 6 commits into from
Aug 31, 2020
Merged

Add instructions to README 📖 #139

merged 6 commits into from
Aug 31, 2020

Conversation

slashmo
Copy link
Owner

@slashmo slashmo commented Aug 28, 2020

No description provided.

@slashmo slashmo added the documentation Improvements or additions to documentation label Aug 28, 2020
@slashmo slashmo added this to the Coding Period 3 milestone Aug 28, 2020
@slashmo slashmo requested a review from ktoso August 28, 2020 20:35
@slashmo slashmo self-assigned this Aug 28, 2020
@slashmo slashmo added this to In progress in Development via automation Aug 28, 2020
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a start 👍

Some minor comments and we'll keep polishing this readme a lot in the weeks to come before GA 👍

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Development automation moved this from In progress to Reviewer approved Aug 29, 2020
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re approving, good improvements 👍

@@ -172,7 +172,7 @@ func get(url: String, context: BaggageContextCarrier) {
// inject the request headers into the baggage context as explained above

// start a span for the outgoing request
let tracer = InstrumentationSystem.tracingInstrument
let tracer = InstrumentationSystem.tracer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great btw, this on was bothering me for a while hehe

@slashmo slashmo merged commit 4cc3412 into main Aug 31, 2020
Development automation moved this from Reviewer approved to Done Aug 31, 2020
@slashmo slashmo deleted the documentation branch August 31, 2020 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants