Fixed build failing for iOS and iPad #23
Conversation
No processInfo username property on iPad and iOS
There was a problem hiding this comment.
Hey @snkirov, thanks for the pull request 🚀 Running on iOS/iPadOS wasn't something I considered when initially building the library since it's a bit more geared towards server-side use. Nonetheless, I want to at least make it compile on these platforms for folks who'd find it useful there too.
Hey @slashmo. I am currently developing an Observability framework with logs, metrics, and traces in Swift for mobile applications. Your framework has been of great help since I am relying on it for exporting the traces. Even though iOS and iPadOS are not the main focus of this library, it's great that it supports them. Would you be interested if I were to add build tests for iOS and iPadOS so that similar issues can be avoided in the future? |
Definitely, great idea! 👍 As mentioned above, I need to rework the CI a bit in general, but if you'd be up for it I'd love to have it run the tests on an iOS/iPadOS simulator as well. |
No worries at all. Just ping me when you are ready and I will do it. |
Regarding this I figured out what has to be done, in order for iOS tests to run as well. I am not sure, whether I should commit these changes to this PR or open a new one, so for now I will just describe the steps. Firstly 2 more schemes need to be added to the project:
Then, the following commands have to be executed on the host, so that the tests can be ran.
In order to do this, swift command line tools have to be installed on the host doing the CI. I am not completely sure whether tests for both iPhone and iPad are necessary, since they are both considered a part of the iOS platform. A simple |
* [CI] Use Package.swift contents as cache key * [CI] Add Swift 5.6 to matrix * [CI] Use relative path for cache keys * [CI] Compile onboarding example on runner
|
@snkirov Thank you very much for investigating! 🙏 I fixed the CI In general now, and looked into possibly running them on an iOS simulator.
Since we currently don't have a project checked into Git, one thing that works is referencing the Swift Package inside an Xcode Workspace (thanks @fabianfett for the pointer ✌️), then adding a scheme to that workspace. As for the schemes, I think one called "UnitTests" will suffice, configured to run both test suites. In terms of how to proceed with this PR, I'd suggest that we do the following:
Does that sound good? Again, thanks for your effort in getting this PR/project forward ❤️ |
No processInfo username property on iPad and iOS
@slashmo This sounds like a solid plan. I rebased and pushed the changes. So now you can merge the PR and open the new one with the workspace & schemes.
For the final step, do I need to open a new PR in order to edit the github actions, or how does it work? Otherwise, I would love to do it. |
|
Awesome, thank you! 🙏
Yep, I think adding a new job (something like |
The build was failing for iOS and iPad, due to the package wanting to access the processinfo.username property. This property keeps track of which user is currently logged in on MacOS and thus is unavailable on iOS and iPad, where we only have a single user.
This short PR fixes the problem.
Link to Apple documentation for reference.