Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update input-_slug styles. #4

Merged
merged 3 commits into from
Dec 23, 2015
Merged

Update input-_slug styles. #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22efa79
Update input-_slug styles.
alexkravets Dec 23, 2015
903bf24
Fix hound comments.
alexkravets Dec 23, 2015
bb40165
Add hound configuration, ignore convention for selector names.
alexkravets Dec 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
ants (0.3.12)
ants (0.3.13)
devise
meta-tags
mongoid (>= 4.0)
Expand Down
3 changes: 2 additions & 1 deletion app/assets/stylesheets/ants.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
@import "ants/profile";
@import "ants/settings";
@import "ants/content";
@import "ants/menu";
@import "ants/menu";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline

@import "ants/slug";
17 changes: 0 additions & 17 deletions app/assets/stylesheets/ants/content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,23 +49,6 @@
.input-_slug {
padding-top: 0;
opacity: 0.5;

.label {
display: inline-block;
font-size: .8em;
cursor: pointer;
}

.error-message {
display: none;
}

input {
display: inline-block;
width: 18em;
font-size: .8em;
padding: 0;
}
}

.publish { display: none; }
Expand Down
20 changes: 20 additions & 0 deletions app/assets/stylesheets/ants/slug.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
.input-_slug {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector input-_slug should be written in lowercase with hyphens

font-size: 0.8em;
padding-left: 1.25em;
padding-right: 1.25em;

.label {
display: inline-block;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered cursor, display

cursor: pointer;
}

.error-message {
display: none;
}

input {
display: inline-block;
width: 18em;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, padding, width

padding: 0;
}
}
2 changes: 1 addition & 1 deletion lib/ants/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Ants
VERSION = "0.3.12"
VERSION = "0.3.13"
end