Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

(not urgent) Formatting pass #575

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

(not urgent) Formatting pass #575

wants to merge 3 commits into from

Conversation

LincolnBryant
Copy link
Contributor

This does a formatting pass across the squid chart to properly align comments and will chomp extraneous newlines, so the output via helm template looks much cleaner.

E.g., before:

kind: Service
apiVersion: v1
metadata:
  name: osg-frontier-squid
  labels:
    app: osg-frontier-squid
    release: RELEASE-NAME
    instance: ""
spec:
  type: NodePort
  
  externalTrafficPolicy: Local
  
  selector:
    app: osg-frontier-squid
    release: RELEASE-NAME
    instance: ""
  ports:
  - port: 3128
    name: cache
    targetPort: squid
    
    
    
  - port: 3401
    name: monitoring
    targetPort: monitoring
    protocol: UDP

After:

kind: Service
apiVersion: v1
metadata:
  name: osg-frontier-squid
  labels:
    app: osg-frontier-squid
    release: RELEASE-NAME
    instance: ""
spec:
  type: NodePort
  externalTrafficPolicy: Local
  selector:
    app: osg-frontier-squid
    release: RELEASE-NAME
    instance: ""
  ports:
  - port: 3128
    name: cache
    targetPort: squid
  - port: 3401
    name: monitoring
    targetPort: monitoring
    protocol: UDP

@adamhgriffith-uofu
Copy link
Contributor

Checking in on the status of this work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants