enhancing plugin, adding Icinga2 examples #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Icinga2 command definition
Added following commands: * server -> check status of Load Balancing Servers * hwinfo -> just print information about the Netscaler itself * interfaces -> check state of all interfaces and add performance data for each interface
added option "performancedata" to query stats and counters to forward them to a performance tool of your choice
* examples:
* cache
-C performancedata -o ns -n cachetothits,cachetotmisses
* tcp connections
-C performancedata -o ns -n tcpcurclientconn,tcpcurclientconnestablished,tcpcurserverconn,tcpcurserverconnestablished
* http requests
-C performancedata -o ns -n httprxrequestbytesrate,httprxresponsebytesrate,httptotrequests,httptotresponses,httptotrxrequestbytes,httptotrxresponsebytes
Now it is possible to get performance data from arrays like Interface. * identifier and field name need to be separated by '.' * example Interface endpoint: -C performancedata -o Interface -n id.tottxbytes,id.totrxbytes
check the state of a servicegroup and its members
now you can define (in percent) how many servicegroup members can go DOWN until you get a WARNING or CRITICAL output
I like the name of the function
Adding command line option -x / --urlopts to set NITRO URL options for further filtering in debug mode
|
Hi Ricardo, thank you for this awesome Pull request. Great work. Seems like you put a lot of time into this. ;) I really love the idea of your performancedata check. All your other changes and improvements makes sense as well. I will merge this into the development branch first. I would like to add a few improvements to the documentation. After that i'll merge this into the master branch and create a new tag. Keep up the good work! |
This was referenced Aug 12, 2017
Merged
|
thank you. it's seems you were quite busy over the weekend as well. Great job. I will the new version to our enviroment and do some test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a few commands and Icinga2 config examples.
This pull request doesn't break any current plugin behaviors!
New commands:
New CLI option
New examples
Added examples to add Netscaler checks to Icinga2
Other changes
I know it's a huge pull request. I usually like them more atomic.
I hope this is ok and you'll like it.
Cheers
Ricardo