can't shift by more than length - release

sle118 · Dec 28, 2021 · 1ee0a23 · 1ee0a23
1 parent 0d411d7
commit 1ee0a23
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/components/services/gpio_exp.c b/components/services/gpio_exp.c
@@ -463,7 +463,7 @@ void service_handler(void *arg) {
 				xSemaphoreGive(expander->mutex);
 				ESP_LOGD(TAG, "Handling GPIO %d reads 0x%04x and has 0x%04x pending", expander->first, expander->shadow, pending);
 
-				for (int gpio = 31, clz; pending; pending <<= (clz + 1)) {
+				for (int gpio = 31, clz = 0; pending && clz < 31; pending <<= (clz + 1)) {
 					clz = __builtin_clz(pending);
 					gpio -= clz;
 					if (expander->isr[gpio].timer) xTimerReset(expander->isr[gpio].timer, 1);	// todo 0